-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for nrfx_config cleanup #259
Open
masz-nordic
wants to merge
2
commits into
zephyrproject-rtos:master
Choose a base branch
from
masz-nordic:nrfx_config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masz-nordic
force-pushed
the
nrfx_config
branch
3 times, most recently
from
November 22, 2024 10:23
830efbe
to
602c405
Compare
CC @e-rk |
masz-nordic
force-pushed
the
nrfx_config
branch
from
November 25, 2024 11:07
602c405
to
d85bb84
Compare
ankuns
reviewed
Nov 26, 2024
masz-nordic
force-pushed
the
nrfx_config
branch
from
November 26, 2024 16:36
d85bb84
to
9e6813f
Compare
ankuns
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drivers/nrf_802154 looks ok
nika-nordic
approved these changes
Nov 27, 2024
PPI hal cannot be used in config files. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
nrfx_config
branch
from
December 4, 2024 17:36
9e6813f
to
cf14636
Compare
Non-secure targets for nRF53 and nRF91 need to define peripherals with _NS. Also, there is a special case for GPIOTE. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
nrfx_config
branch
from
December 5, 2024 10:18
cf14636
to
bdaf805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.